Skip to content

Commit

Permalink
Update sdk/python/feast/infra/offline_stores/redshift.py
Browse files Browse the repository at this point in the history
Co-authored-by: Willem Pienaar <6728866+woop@users.noreply.github.com>
Signed-off-by: Tsotne Tabidze <tsotne@tecton.ai>
  • Loading branch information
2 people authored and Tsotne Tabidze committed Jul 21, 2021
1 parent 7bed4b0 commit 1da26bf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sdk/python/feast/infra/offline_stores/redshift.py
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def _upload_entity_df_and_get_entity_schema(
raise InvalidEntityType(type(entity_df))


# This is based on sdk/python/feast/infra/offline_stores/bigquery.py:MULTIPLE_FEATURE_VIEW_POINT_IN_TIME_JOIN
# This query is based on sdk/python/feast/infra/offline_stores/bigquery.py:MULTIPLE_FEATURE_VIEW_POINT_IN_TIME_JOIN
# There are couple of changes from BigQuery:
# 1. Use VARCHAR instead of STRING type
# 2. Use DATEADD(...) instead of Timestamp_sub(...)
Expand Down

0 comments on commit 1da26bf

Please sign in to comment.