chore: Commenting out Milvus tests and removing from integration test…

…s configuration (#4888) chore: Cmomenting out milvus tests and removing from integration configuration Signed-off-by: Francisco Javier Arceo <farceo@redhat.com>
feast-dev · Jan 3, 2025 · 170e2f0 · 170e2f0
1 parent ef724b6
commit 170e2f0
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 24 deletions.
diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py
@@ -163,7 +163,7 @@
     AVAILABLE_ONLINE_STORES["datastore"] = ("datastore", None)
     AVAILABLE_ONLINE_STORES["snowflake"] = (SNOWFLAKE_CONFIG, None)
     AVAILABLE_ONLINE_STORES["bigtable"] = (BIGTABLE_CONFIG, None)
-    AVAILABLE_ONLINE_STORES["milvus"] = (MILVUS_CONFIG, None)
+    # AVAILABLE_ONLINE_STORES["milvus"] = (MILVUS_CONFIG, None)
 
     # Uncomment to test using private IKV account. Currently not enabled as
     # there is no dedicated IKV instance for CI testing and there is no

diff --git a/sdk/python/tests/integration/online_store/test_universal_online.py b/sdk/python/tests/integration/online_store/test_universal_online.py
@@ -897,26 +897,26 @@ def test_retrieve_online_documents(environment, fake_document_data):
         ).to_dict()
 
 
-@pytest.mark.integration
-@pytest.mark.universal_online_stores(only=["milvus"])
-def test_retrieve_online_milvus_documents(environment, fake_document_data):
-    fs = environment.feature_store
-    df, data_source = fake_document_data
-    item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
-    fs.apply([item_embeddings_feature_view, item()])
-    fs.write_to_online_store("item_embeddings", df)
-    documents = fs.retrieve_online_documents(
-        feature=None,
-        features=[
-            "item_embeddings:embedding_float",
-            "item_embeddings:item_id",
-            "item_embeddings:string_feature",
-        ],
-        query=[1.0, 2.0],
-        top_k=2,
-        distance_metric="L2",
-    ).to_dict()
-    assert len(documents["embedding_float"]) == 2
-
-    assert len(documents["item_id"]) == 2
-    assert documents["item_id"] == [2, 3]
+# @pytest.mark.integration
+# @pytest.mark.universal_online_stores(only=["milvus"])
+# def test_retrieve_online_milvus_documents(environment, fake_document_data):
+#     fs = environment.feature_store
+#     df, data_source = fake_document_data
+#     item_embeddings_feature_view = create_item_embeddings_feature_view(data_source)
+#     fs.apply([item_embeddings_feature_view, item()])
+#     fs.write_to_online_store("item_embeddings", df)
+#     documents = fs.retrieve_online_documents(
+#         feature=None,
+#         features=[
+#             "item_embeddings:embedding_float",
+#             "item_embeddings:item_id",
+#             "item_embeddings:string_feature",
+#         ],
+#         query=[1.0, 2.0],
+#         top_k=2,
+#         distance_metric="L2",
+#     ).to_dict()
+#     assert len(documents["embedding_float"]) == 2
+#
+#     assert len(documents["item_id"]) == 2
+#     assert documents["item_id"] == [2, 3]