New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pregenerate requests before serving #4

Merged

khorshuheng merged 1 commit into feast-dev:master from khorshuheng:pregenerated-requests

Jan 21, 2021

Collaborator

khorshuheng commented Jan 21, 2021

Signed-off-by: khorshuheng solemnpriest@gmail.com

Generates the online requests before serving. This serves two purposes:

The process of generating random requests does not affect the serving latency.
The hash map for the value pool is not thread safe. Hence under high concurrency, there are some race condition that leads to non unique entity row.


          Pregenerate requests before serving

e950ef8

Signed-off-by: khorshuheng <solemnpriest@gmail.com>

khorshuheng merged commit 8e61716 into feast-dev:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet