feat: topic management #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51adab4 to
e57ab8c
Compare
monxxi
reviewed
Jun 9, 2020
There was a problem hiding this comment.
An other point,
i test this scenario:
1 - First, with the BigBang Mode:
- generate only producer for an entity
2 - After, with Incremental mode
- generate the consumer for the same previous entity
- choose default_topic option
the result :
the key case seems to be wrong with the incremental mode
generators/app/templates/src/main/resources/application-kafka.yml.ejs
Outdated
Show resolved
Hide resolved
2313612 to
8e650c5
Compare
b1461a6 to
6427dea
Compare
379b550 to
659d4ed
Compare
9e86b8f to
ad9d37c
Compare
042d533 to
f659935
Compare
f659935 to
4d8599b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed