feat: handle deserialization error #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2b12d10 to
f368e83
Compare
|
Don't forget to sign CLA @ctamisier :) |
fdelbrayelle
requested changes
May 30, 2020
generators/app/templates/src/main/java/package/service/kafka/consumer/EntityConsumer.java.ejs
Outdated
Show resolved
Hide resolved
...s/app/templates/src/main/java/package/service/kafka/deserializer/EntityDeserializer.java.ejs
Outdated
Show resolved
Hide resolved
9cdd861 to
9c4e433
Compare
fdelbrayelle
previously requested changes
May 31, 2020
...ors/app/templates/src/main/java/package/service/kafka/deserializer/DeserializeError.java.ejs
Outdated
Show resolved
Hide resolved
...ors/app/templates/src/main/java/package/service/kafka/deserializer/DeserializeError.java.ejs
Outdated
Show resolved
Hide resolved
50936d9 to
28fe9f1
Compare
fa37c0d to
9a284f4
Compare
b63eb83 to
052a044
Compare
4436071 to
9933831
Compare
Co-authored-by: François Delbrayelle <fdelbrayelle@gmail.com>
9933831 to
fb3fa57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure the below checklist is followed for Pull Requests.
All continuous integration tests are green
Tests are added where necessary
Documentation is added/updated where necessary
Coding Rules & Commit Guidelines as per our CONTRIBUTING.md document are followed