Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add prompt for polling timeout #40

Merged
merged 7 commits into from
May 18, 2020

Conversation

monxxi
Copy link
Collaborator

@monxxi monxxi commented May 15, 2020

fix #32

@CLAassistant
Copy link

CLAassistant commented May 15, 2020

CLA assistant check
All committers have signed the CLA.

@monxxi monxxi requested a review from fdelbrayelle May 15, 2020 15:09
@monxxi monxxi marked this pull request as ready for review May 15, 2020 15:10
@monxxi monxxi force-pushed the feature/32-add-prompt-for-polling branch from cca7739 to 16435b2 Compare May 17, 2020 10:39
@fdelbrayelle fdelbrayelle changed the title append prompt for polling feat: add prompt for polling timeout May 18, 2020
@monxxi monxxi force-pushed the feature/32-add-prompt-for-polling branch from b1d6d2e to 652dac6 Compare May 18, 2020 09:57
@monxxi monxxi requested a review from fdelbrayelle May 18, 2020 10:24
@monxxi
Copy link
Collaborator Author

monxxi commented May 18, 2020

@fdelbrayelle, as seen together, I changed the way how application yaml file is bound to fully use it in kafka properties.
Additional question: keep it like that? or use nested classes in kafka properties?

@monxxi monxxi merged commit 7848fab into fdelbrayelle:master May 18, 2020
@monxxi monxxi mentioned this pull request May 18, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

consumer: Prompt option for poll time
3 participants