Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: backporting PR#29949 #10

Closed
wants to merge 1 commit into from
Closed

Conversation

felipemontoya
Copy link
Member

@felipemontoya felipemontoya commented May 11, 2023

Description

This PR is a backport of openedx/edx-platform#29949.

However that work was also blocked by

Useful information to include:

  • The core of the PR adds the CertificateCreationRequested filter. The differences with the original PR are adaptations to make the code run.

Supporting information

https://plataforma-nau.atlassian.net/browse/FAN-107

Testing instructions

Generate a certificate. Nothing should fail.

Deadline

Before we migrate to Olive. If not then it is no longer necessary.

Other information

To be fully functional, this change requires a filter implementation at the nau-plugin. However I'd like to test the assumption that with the imminent migration to olive Nutmeg, backporting this still makes sense.

@felipemontoya felipemontoya requested a review from igobranco May 11, 2023 03:35
@igobranco igobranco closed this Jun 27, 2024
@igobranco
Copy link
Member

We no longer need this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants