[FE-2590] add client endpoint param #652
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Jira Ticket
The endpoint parameter is supported by other drivers. Implement it for the JS driver.
Those drivers that support endpoint do not support the scheme + domain + port parameters, so we need to determine how to handle the case where endpoint and the others are included. My suggestion is that if endpoint is set, then the other three are ignored, and that is what this PR does.
The JS driver accepts and optional argument with override options for the client.query and client.queryWithMetrics methods, but any overrides for scheme, domain, or port will not have any effect. No additional checks are required to handle query options.
Use cases
/linearized
endpoint is not currently useable with the python driver. Or at least not reasonably. You can specify the port as443/linearized
to make it work, but it is not reasonable to advise folks to do this.port
parameter.How to test
A test was added. No changes in environment or configuration are required to run the test.