fix: ContainsStr FQL to string #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marrony
requested changes
Sep 13, 2021
There was a problem hiding this comment.
Please, add test for this change
Here is a good place https://github.com/fauna/faunadb-js/blob/main/test/values.test.js#L247
parkhomenko
previously approved these changes
Sep 23, 2021
parkhomenko
previously approved these changes
Sep 24, 2021
marrony
reviewed
Oct 4, 2021
marrony
previously approved these changes
Oct 4, 2021
fireridlle
added a commit
that referenced
this pull request
Oct 18, 2021
* tests(OSS-92): remove resources after all test completed (#527) * tests(OSS-92): remove resources after all test completed * tests: posttest * posttest * posttest * posttest * fix: ContainsStr FQL to string (#537) * fix: ContainsStr FQL to string * test * fix * move test * OSS-906 fix: restore _isFaunaValue and _isFaunaRef properties (#529) * fix: restore _isFaunaValue and _isFaunaRef properties * test: added tests for values type-helpers * Add toFQL() to type declaration for Expr (#544) I wanted to print a query as FQL for debugging purposes, but didn't find the toFQL method because it wasn't in the type declaration. A helpful person on StackOverflow pointed it out to me. https://stackoverflow.com/questions/69418846/how-can-i-print-an-fql-query-from-javascript-as-a-string-e-g-to-test-it-in-the/69472058 * fix tests clean (#545) * TGB-921 page helper (#543) * TGB-921 page helper * remove page.data.forEach as it's deprecated * fix test * fix test * debug auth0 tests (#546) * slack notification (#547) * OSS-953 Consolidate query timeout for v5 Co-authored-by: Paul Paterson <ptpaterson@gmail.com> Co-authored-by: Kevin <89287578+ktint@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
OSS-888