Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godoc deprecated StartTime #184

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Godoc deprecated StartTime #184

merged 2 commits into from
Nov 12, 2024

Conversation

cynicaljoy
Copy link
Contributor

@cynicaljoy cynicaljoy commented Nov 12, 2024

BT-5313

Description

Adds godoc comment deprecation notice for StartTime

Motivation and context

We'll be updating the API to use time.Time to enable a more native UX

How was the change tested?

N/A

Screenshots (if appropriate):

Change types

    • Bug fix (non-breaking change that fixes an issue)
    • New feature (non-breaking change that adds functionality)
    • Breaking change (backwards-incompatible fix or feature)

Checklist:

    • My code follows the code style of this project.
    • My change requires a change to Fauna documentation.
    • My change requires a change to the README, and I have updated it accordingly.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@cynicaljoy cynicaljoy requested a review from pnwpedro November 12, 2024 17:31
@cynicaljoy cynicaljoy merged commit a28ae91 into v2 Nov 12, 2024
5 checks passed
@cynicaljoy cynicaljoy deleted the godoc-deprecated-startts branch November 12, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants