Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align regex for device ID's for gateways #801

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

noursaidi
Copy link
Collaborator

No description provided.

@noursaidi noursaidi requested a review from grafnu February 2, 2024 12:03
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd do a bit more of a scan to make sure there's not other rogue instances, otherwise we're likely to come across this again and again! E.g.,

peringknife@peringknife-glaptop4:~/udmi$ fgrep -e -[0-9] -r schema/
schema/model_system.json:              "pattern": "^[A-Z]{2,6}-[0-9]{1,6}$"
schema/model_gateway.json:      "pattern": "^[A-Z]{2,6}-[0-9]{1,6}$",
schema/model_gateway.json:        "pattern": "^[A-Z]{2,6}-[0-9]{1,6}$"
schema/state_validation.json:        "^[A-Z]{2,6}-[0-9]{1,6}$": {
schema/envelope.json:      "pattern": "^[A-Z]{2,6}-[0-9]{1,6}$"
schema/envelope.json:      "pattern": "^[A-Z]{2,6}-[0-9]{1,6}$"

@grafnu grafnu merged commit 45f7873 into faucetsdn:master Feb 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants