Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pubber gateway proxy runtime issues #787

Merged
merged 15 commits into from
Jan 26, 2024
Merged

Fix pubber gateway proxy runtime issues #787

merged 15 commits into from
Jan 26, 2024

Conversation

MertCingoz
Copy link
Collaborator

No description provided.

@MertCingoz MertCingoz marked this pull request as ready for review January 3, 2024 14:02
@noursaidi noursaidi requested a review from grafnu January 18, 2024 18:50
grafnu
grafnu reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall seems on track, I think most/all of the comments are local considerations.

.gitignore Show resolved Hide resolved
pubber/src/main/java/daq/pubber/BasicPoint.java Outdated Show resolved Hide resolved
pubber/src/main/java/daq/pubber/ManagerBase.java Show resolved Hide resolved
pubber/src/main/java/daq/pubber/ManagerBase.java Outdated Show resolved Hide resolved
pubber/src/main/java/daq/pubber/ManagerBase.java Outdated Show resolved Hide resolved
pubber/src/main/java/daq/pubber/Pubber.java Outdated Show resolved Hide resolved
pubber/src/main/java/daq/pubber/Pubber.java Outdated Show resolved Hide resolved
pubber/src/main/java/daq/pubber/Pubber.java Outdated Show resolved Hide resolved
validator/src/main/java/com/google/daq/mqtt/sequencer/SequenceBase.java Outdated Show resolved Hide resolved
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java Outdated Show resolved Hide resolved
@MertCingoz MertCingoz requested a review from grafnu January 22, 2024 15:43
grafnu
grafnu reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's still some failing unit tests -- let me know if you have questions about what they mean. The tests can be a bit cryptic, but they are easy to fix.

pubber/src/main/java/daq/pubber/ManagerBase.java Show resolved Hide resolved
pubber/src/main/java/daq/pubber/ManagerBase.java Outdated Show resolved Hide resolved
pubber/src/main/java/daq/pubber/ProxyDevice.java Show resolved Hide resolved
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java Outdated Show resolved Hide resolved
@MertCingoz
Copy link
Collaborator Author

Just reverted schema upgrade. Unit tests require manual upgrade of sample site model and trace files which I think it should be also handled in another PR

@MertCingoz MertCingoz requested a review from grafnu January 23, 2024 09:15
@grafnu grafnu merged commit c2cb48a into faucetsdn:master Jan 26, 2024
7 of 8 checks passed
@MertCingoz MertCingoz deleted the pubber-fix branch January 26, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafnu grafnu grafnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MertCingoz @grafnu