Validator message window and report contents #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2022
noursaidi
approved these changes
Sep 5, 2022
|
Ok -- should fix the null file pubsub case... Can you give it a whirl and see if it fixes for you as well? |
noursaidi
approved these changes
Sep 5, 2022
johnrandolph
reviewed
Sep 6, 2022
johnrandolph
reviewed
Sep 6, 2022
| @@ -9,15 +9,15 @@ | |||
| import java.util.Optional; | |||
| import java.util.regex.Pattern; | |||
|
|
|||
| public class DeviceExceptionManager { | |||
| class DeviceExceptionManager { | |||
There was a problem hiding this comment.
Is this a lint-based change?
There was a problem hiding this comment.
yes -- public classes require javadoc, and there's no need for this to be public since it's only used internally.
| return new File(deviceDir, String.format("%s_%s.%s", subType, subFolder, suffix)); | ||
| boolean invalid = subFolder == null || "update".equals(subFolder); | ||
| return new File(deviceDir, | ||
| String.format("%s%s.%s", subType, invalid ? "" : "_" + subFolder, suffix)); |
There was a problem hiding this comment.
Suggestion, use the string format to without additional tiny + string concat in the arguments?
There was a problem hiding this comment.
Updated to make it, er, less ugly.
johnrandolph
approved these changes
Sep 6, 2022
noursaidi
pushed a commit
to noursaidi/udmi
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses multiple issues pertaining to validator. Includes a refactor that processes "recent messages" rather than just the "ast message" -- so should be more generalizable and scalable.