Add reflector utility #408
Conversation
bin/reset_config
Outdated
| cd $ROOT | ||
|
|
||
| device_config=/tmp/${device_id}_config.json | ||
| cp $site_dir/devices/${device_id}/out/generated_config.json $device_config |
There was a problem hiding this comment.
Be consistent and ${var} everywhere?
bin/reset_config
Outdated
|
|
||
| device_config=/tmp/${device_id}_config.json | ||
| cp $site_dir/devices/${device_id}/out/generated_config.json $device_config | ||
| now_date=$(date -Ins -u | sed -E 's/.{6}\+.*/Z/' | tr , .) |
There was a problem hiding this comment.
I love shell manipulation but we have to worry about OSX compat (if we target that) and one needs to run it to see what it does.
We already depend on python. What do you think of this oneliner? We could throw it into bin/util_output_utcnow_8601 or whatever.
print(datetime.datetime.utcnow().isoformat())
2022-08-04T13:44:21.327511
bin/reset_config
Outdated
| cp $site_dir/devices/${device_id}/out/generated_config.json $device_config | ||
| now_date=$(date -Ins -u | sed -E 's/.{6}\+.*/Z/' | tr , .) | ||
| echo Setting config timestamp $now_date | ||
| jq .timestamp=\"$now_date\" < $device_config | sponge $device_config |
There was a problem hiding this comment.
Update: Just comment sponge is a Linuxism or whatever
There was a problem hiding this comment.
added runtime check and warning message, would have to fix actual OSX compat in another round (with QA)
| jarfile=validator/build/libs/validator-1.0-SNAPSHOT-all.jar | ||
| mainclass=com.google.daq.mqtt.validator.Reflector | ||
|
|
||
| cmd="java -cp $jarfile $mainclass -p $project_id -s $site_dir -d $device_id $*" |
There was a problem hiding this comment.
Why not just invoke directly and "$*" on end?
There was a problem hiding this comment.
there was supposed to be another diagnostic "echo" in there... added!
| } | ||
|
|
||
| private void reflect(String topic, String data) { | ||
| client.publish(deviceId, topic, data); |
There was a problem hiding this comment.
Is this going to verify that the json input is well-formed?
There was a problem hiding this comment.
No -- it's not actually even strictly JSON. This was meant as a reasonably low-level utility that wasn't really opinionated about formats. Maybe future iterations could add a "validate schema" flag or something... E.g. this tool can be used to validate that a borked garbage config does not tank the system.
|
|
||
| if [[ $# != 3 ]]; then | ||
| echo Usage: $0 site_dir project_id device_id | ||
| false |
There was a problem hiding this comment.
Do you want exec false? or just exit 1?
There was a problem hiding this comment.
I avoid "exit 1" because sometimes I'll end up doing "source" on a script and then "exit 1" will totally bork the shell session... the behavior of "false" is only that if the -e flag is specified. So, in this particular case they are functionally equivalent, but I'm not sure if there's really a compelling reason for one over the other in the big picture.
bin/reset_config
Outdated
| cp $site_dir/devices/${device_id}/out/generated_config.json $device_config | ||
| now_date=$(date -Ins -u | sed -E 's/.{6}\+.*/Z/' | tr , .) | ||
| echo Setting config timestamp $now_date | ||
| jq .timestamp=\"$now_date\" < $device_config | sponge $device_config |
There was a problem hiding this comment.
Update: Just comment sponge is a Linuxism or whatever
| if [[ $# < 4 ]]; then | ||
| echo Usage: $0 site_dir project_id device_id directive [directives...] | ||
| echo " Directive is something like update/config:sites/udmi_site_model/devices/AHU-1/out/generated_config.json" | ||
| false |
There was a problem hiding this comment.
same as other comment... not sure if there's a clear reason for one over the other because they're just "different" in how they handle different edge use cases...
This adds a basic utility that can be used to inject messages into the system through the reflector. This is used by testing scripts to, for example, reset or modify a device config.