-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge UDMIF into faucetsdn UDMI #296
Conversation
updated duplicate gcp_project to gcp_region
Update udmi-sites.tf.template
Created build.yml
Added build stage for terraform
updated gcp build
Gcp terraform
Support contains query
Adding contains filter
Corrected env variable
Adding sub total and sorting capabilities
Env variables
created project fro gcp
testing mongodb
Update mongodb.tf
created db user
"rename udmd to udmif in .gitlab-ci"
Renaming folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's one stray .zip file cloud/gcp/function.zip? Or, if it's intended, what is that?
cloud/gcp/index.js is empty -- seems like it only half got moved to cloud/gcp/src/ --?
I spoke to the IaC team. They're reviewing their work and should get to updating this next week. |
There's still a cloud/gcp/index.js and cloud/gcp/src/index.js file... are they both right? Also cloud/gcp/package.json is an exact copy of cloud/gcp/src/package.json... ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The index.js and package.json files under cloud/gcp/src and cloud/gcp seem redundant... are both sets supposed to be there?
For now, I'm acting as the middle man of this PR. I've let the team know about your latest comments. |
Those were put there temporary to be able to deploy the cloud function. This will be dynamic in the next PR. We will delete that src folder. |
This is an initial merge of the UDMIF projects which includes an Angular front end and a GraphQL API service. It also includes a preliminary IaC implementation. All of the work is in progress.