Discovery Scanning & Enumeration #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noursaidi
reviewed
Feb 1, 2022
|
Ok, this PR is way too long but feature complete. Unfortunately a new feature like this requires changes across many different sub-parts of the code-base so I'm not entirely sure how to break it up into reasonable size chunks that also have meaning on their own. (That and I was bad and threw in some lint refactoring). If somebody thinks it's too big to process let me know and I can try to break it up -- otherwise just take your time to go through it. |
|
Ok -- I'm refactoring out basic bits into other PRs and will return to this one (code changes) when it's a bit more sane. |
johnrandolph
approved these changes
Apr 20, 2022
| } | ||
| } | ||
| if (t != null) { | ||
| System.out.println(t); |
| /** | ||
| * Validation tests for discovery scan and enumeration capabilities. | ||
| */ | ||
| public class DiscoveryValidator extends SequenceValidator { |
There was a problem hiding this comment.
May need to refactor these into smaller pieces in the future but ok to get started now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at documentation for discovery & enumeration. Goal is to have something concrete in place for ongoing onboarding discussions, and then can finalize/iterate over time.