Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gendocs git friendly #209

Merged
merged 2 commits into from
Dec 8, 2021
Merged

Conversation

noursaidi
Copy link
Collaborator

Issue #208

Try to make gendocs more git friendly and avoid merge conflicts by removing times from footer and fixing the version of the json-schema-for-humans library so that the HTML is not minified.

Alternatively can we setup gendocs and the other code generators be setup to run as GitHub Actions when there is a merge which changes the schema JSON files?

@noursaidi noursaidi requested a review from grafnu December 6, 2021 16:07
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gitHub actions thing is a neat idea -- but I'd leave that as a separate activity (form this PR)...

bin/gendocs Outdated Show resolved Hide resolved
bin/gendocs Outdated Show resolved Hide resolved
@noursaidi noursaidi requested a review from grafnu December 6, 2021 18:29
@noursaidi noursaidi merged commit 209330c into faucetsdn:master Dec 8, 2021
@noursaidi noursaidi deleted the gendocsgitfriendly branch September 20, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants