Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON Documentation & Document Generator #180

Merged
merged 13 commits into from
Sep 9, 2021

Conversation

noursaidi
Copy link
Collaborator

Adds document generator to convert JSON schema into HTML files. Also included the HTML version of the current schema.

Preview - https://noursaidi.github.io/udmi/schema/index.html

Suggest that GitHub Pages is enabled on the docs directory to allow it to be viewed nicely from the web.

@noursaidi
Copy link
Collaborator Author

I've now added the more basic descriptions to this PR and many of the descriptions which already exist in the current documentation

test adding github action

A

FIX TABS

fix tabs but actually save

remove java from doc checker

test doc

check check hashes

restore
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some pre-review comments.

Also, what do you think about relocating the files to gencode/docs rather than docs/schema? The reason is that it's nice to keep everything that's automatically generated in one place so it doesn't get mixed in with manual edits. Right now, everything else in gencode/ is automatically generated, so seems reasonable.

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be comitted! Likely need to add it to .gitignore or similar.

steps:
- uses: actions/checkout@v2
- name: schema docs
run: bin/gendocs check
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline at end of file!

@noursaidi
Copy link
Collaborator Author

Resolved pre-review comments and moved directory into gencode/docs. Most of the more straightforward definitions which already exist in the current documentation have been copied over, rest of definitions to come later.

New web preview link - https://noursaidi.github.io/udmi/gencode/docs/

@noursaidi noursaidi requested a review from grafnu September 8, 2021 21:54
bin/gendocs Outdated Show resolved Hide resolved
@noursaidi
Copy link
Collaborator Author

Indent fixed - ready to be merged now

@grafnu grafnu merged commit d3b129e into faucetsdn:master Sep 9, 2021
@noursaidi noursaidi deleted the docgenerator branch September 20, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants