Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init dashboard #118

Merged
merged 10 commits into from
Mar 22, 2021
Merged

init dashboard #118

merged 10 commits into from
Mar 22, 2021

Conversation

henry54809
Copy link
Collaborator

No description provided.

@henry54809 henry54809 requested review from grafnu and pbatta March 17, 2021 05:28
grafnu
grafnu reviewed Mar 17, 2021
View reviewed changes
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main question is the user-specific info that's in a few places... not sure how that's supposed to work. We likely should find something "neutral" for those -- e.g., bos-daq-testing or daq-testing or something rather than daq-haoli

udms/.firebaserc Outdated Show resolved Hide resolved
udms/e2e/firestore/import_db.js Outdated Show resolved Hide resolved
udms/e2e/firestore/import_db.js Show resolved Hide resolved
udms/functions/package.json Show resolved Hide resolved
udms/src/app/app.component.scss Show resolved Hide resolved
udms/src/environments/environment.ts Outdated Show resolved Hide resolved
@henry54809 henry54809 marked this pull request as ready for review March 20, 2021 19:36
@henry54809
Copy link
Collaborator Author

PTAL.

@henry54809
Copy link
Collaborator Author

@grafnu firebase requires a CI token even with the emulators, would you please follow this section to generate a token and store that in this repo's env var.https://firebase.google.com/docs/cli#cli-ci-systems

@grafnu
Copy link
Collaborator

grafnu commented Mar 20, 2021

Which repo are you talking about for the token? I'd rather get the permissions fixed so that you can do it yourself rather than relying on me. Will make it easier in the future.

Also still one unresolved comment about the functions deploy.

Everything else LGTM.

@henry54809 henry54809 merged commit bc535b5 into faucetsdn:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafnu grafnu grafnu approved these changes

@pbatta pbatta Awaiting requested review from pbatta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henry54809 @grafnu