Automatic build script #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
===========================================
- Coverage 80.30% 23.58% -56.73%
===========================================
Files 22 22
Lines 3753 3753
===========================================
- Hits 3014 885 -2129
- Misses 739 2868 +2129
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
pbatta
reviewed
Jul 23, 2020
| if [ -z "$changed" ]; then | ||
| git log release_stable..HEAD --pretty=oneline | sed -e 's/[a-z0-9]+/\*/g' | ||
| echo docs/changelog.md has not been updated since last release_stable | ||
| echo Use the log lines above for inspiration. |
pbatta
reviewed
Jul 23, 2020
| echo Expected build images not found. Something went wrong. | ||
| false | ||
| fi | ||
|
|
There was a problem hiding this comment.
nit: maybe delete /tmp/git_expected.txt and /tmp/git_status.txt as they are not needed beyond this point?
pbatta
reviewed
Jul 23, 2020
| git push | ||
| git push --tags | ||
|
|
||
| faucetgit=`git config remote.faucet.url` |
There was a problem hiding this comment.
This would be applicable if the users fork of the repo is set up as a remote called 'faucet'? If so, maybe add a comment to that affect?
|
Updated, PTAL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.