Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore gcp combine report test #553

Merged
merged 6 commits into from
Jul 21, 2020

Conversation

henry54809
Copy link
Collaborator

No description provided.

@henry54809 henry54809 requested a review from grafnu July 21, 2020 17:36
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #553 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   80.30%   80.29%   -0.01%     
==========================================
  Files          22       22              
  Lines        3742     3751       +9     
==========================================
+ Hits         3005     3012       +7     
- Misses        737      739       +2     
Flag Coverage Δ
#aux 73.78% <0.00%> (+<0.01%) ⬆️
#base 75.26% <0.00%> (-0.03%) ⬇️
#dhcp 72.08% <100.00%> (+0.06%) ⬆️
#many 72.05% <100.00%> (-0.32%) ⬇️
#modules 23.56% <25.00%> (-0.01%) ⬇️
#topo 72.16% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bin/python/combine_reports_from_date_range.py 86.11% <100.00%> (ø)
daq/ipaddr_test.py 92.42% <100.00%> (+0.11%) ⬆️
daq/stream_monitor.py 87.50% <0.00%> (-0.84%) ⬇️
daq/host.py 90.63% <0.00%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77a6e8...f2c970e. Read the comment docs.

Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor stickler comment...

@henry54809 henry54809 merged commit d5fb5ac into faucetsdn:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants