USI not to use background shell #548
Conversation
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| public class OpenVSwitch implements SwitchController { | |||
|
|
|||
| private static final String OVS_OUTPUT_FILE = "ovs_output.txt"; | |||
| private static final String OVS_OUTPUT_FILE = "sec.ofctl"; | |||
There was a problem hiding this comment.
Also can you please change the test filename? usi/src/test/resources/ovs_output.txt
There was a problem hiding this comment.
Do you know why the test didn't fail? Something like that should have been caught, so seems like something's misconfigured.
There was a problem hiding this comment.
The unit tests aren't setup to run but they will be as part of the github actions migration.
There was a problem hiding this comment.
Ok, renamed test resource... PTAL.
Codecov Report
@@ Coverage Diff @@
## master #548 +/- ##
==========================================
+ Coverage 80.25% 80.29% +0.04%
==========================================
Files 22 22
Lines 3742 3750 +8
==========================================
+ Hits 3003 3011 +8
Misses 739 739
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
No description provided.