Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UDMI to external repo #544

Merged
merged 7 commits into from
Jul 20, 2020
Merged

Refactor UDMI to external repo #544

merged 7 commits into from
Jul 20, 2020

Conversation

grafnu
Copy link
Collaborator

@grafnu grafnu commented Jul 18, 2020

This only contains the substantive changes. There's a bunch of files (pubber/, validator/, schemas/) that need to be deleted, but I'll do that as a separate PR b/c it makes this PR unmanageable (hundreds of changed files). Overall, this PR is functionality neutral.

@grafnu grafnu requested review from henry54809 and pbatta July 18, 2020 06:32
@codecov
Copy link

codecov bot commented Jul 18, 2020

Codecov Report

Merging #544 into master will increase coverage by 3.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #544      +/-   ##
==========================================
+ Coverage   76.45%   80.33%   +3.87%     
==========================================
  Files          22       22              
  Lines        3742     3742              
==========================================
+ Hits         2861     3006     +145     
+ Misses        881      736     -145     
Flag Coverage Δ
#aux 73.88% <ø> (?)
#base 75.28% <ø> (?)
#dhcp 72.04% <ø> (ø)
#many 72.01% <ø> (+0.05%) ⬆️
#modules 23.57% <ø> (ø)
#topo 72.15% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/gateway.py 91.05% <0.00%> (+1.57%) ⬆️
daq/topology.py 96.74% <0.00%> (+1.83%) ⬆️
daq/configurator.py 90.67% <0.00%> (+3.38%) ⬆️
daq/network.py 96.79% <0.00%> (+4.48%) ⬆️
daq/host.py 90.50% <0.00%> (+4.74%) ⬆️
daq/runner.py 87.22% <0.00%> (+5.54%) ⬆️
daq/report.py 100.00% <0.00%> (+6.98%) ⬆️
daq/stream_monitor.py 88.33% <0.00%> (+7.50%) ⬆️
daq/dhcp_monitor.py 100.00% <0.00%> (+9.21%) ⬆️
daq/docker_test.py 97.56% <0.00%> (+20.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9848021...038ef3e. Read the comment docs.

@grafnu grafnu merged commit e77a6e8 into faucetsdn:master Jul 20, 2020
@grafnu grafnu deleted the noudmi branch July 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants