Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GCP combine check #542

Merged
merged 1 commit into from
Jul 18, 2020
Merged

Disable GCP combine check #542

merged 1 commit into from
Jul 18, 2020

Conversation

grafnu
Copy link
Collaborator

@grafnu grafnu commented Jul 17, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #542 into master will decrease coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
- Coverage   80.52%   80.28%   -0.24%     
==========================================
  Files          21       22       +1     
  Lines        3635     3743     +108     
==========================================
+ Hits         2927     3005      +78     
- Misses        708      738      +30     
Flag Coverage Δ
#aux 73.78% <ø> (ø)
#base 75.32% <ø> (ø)
#dhcp 70.28% <ø> (-0.53%) ⬇️
#many 71.91% <ø> (-0.45%) ⬇️
#modules 23.56% <ø> (?)
#topo 72.10% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/gateway.py 91.05% <0.00%> (-3.69%) ⬇️
daq/runner.py 87.39% <0.00%> (-1.52%) ⬇️
bin/python/combine_reports_from_date_range.py 86.11% <0.00%> (ø)
daq/__init__.py 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adb4c25...59472da. Read the comment docs.

@grafnu grafnu merged commit b2bfed7 into faucetsdn:master Jul 18, 2020
@grafnu grafnu deleted the fixbreak branch July 21, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants