Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move NTP test to monitor pcap and do multiple NTP requests to reduce flakiness #541

Merged
merged 4 commits into from
Jul 17, 2020

Conversation

pbatta
Copy link
Collaborator

@pbatta pbatta commented Jul 17, 2020

No description provided.

@pbatta pbatta requested a review from grafnu July 17, 2020 01:49
@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #541 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files          22       22           
  Lines        3727     3743   +16     
=======================================
+ Hits         2993     3006   +13     
- Misses        734      737    +3     
Flag Coverage Δ
#aux 73.86% <ø> (-1.55%) ⬇️
#base 75.32% <ø> (-1.58%) ⬇️
#dhcp 70.37% <ø> (-1.64%) ⬇️
#many 71.91% <ø> (+0.09%) ⬆️
#modules 23.56% <ø> (-0.08%) ⬇️
#topo 72.15% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
daq/ipaddr_test.py 88.70% <0.00%> (-7.04%) ⬇️
daq/host.py 90.73% <0.00%> (-0.18%) ⬇️
daq/stream_monitor.py 88.33% <0.00%> (+0.83%) ⬆️
daq/gateway.py 91.05% <0.00%> (+1.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff20a21...ffcf06b. Read the comment docs.

@pbatta pbatta merged commit adb4c25 into faucetsdn:master Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants