Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NTPv4 support #487

Merged
merged 47 commits into from
Jul 8, 2020
Merged

NTPv4 support #487

merged 47 commits into from
Jul 8, 2020

Conversation

frgitdaq
Copy link
Collaborator

No description provided.

frgitdaq and others added 30 commits April 16, 2020 16:59
@frgitdaq
Merge remote-tracking branch 'upstream/master'
3571754
@frgitdaq
Merge branch 'master' into 340-mac-oui
0210081
@frgitdaq
connection.network.mac_oui test - Expanded report and mac prefixes fe…
26ae024 
…tched from svn nmap
@frgitdaq
Adding the svn nmap URL to fetch the mac prefixes
782934c
@frgitdaq
Merge pull request #1 from frgitdaq/340-mac-oui
895029e 
340 mac oui
@frgitdaq
Update test_aux.out
74ca896 
Updating testing out doc
@frgitdaq
Create readme.md
fc81a84 
Creating readme.md
@frgitdaq
Removed dynamic loading on macList.txt
f4f4209 
The mackList.txt is loaded during docker build time, so removed from the java project
@frgitdaq
Removed static resource macList.txt, updated .gitignore and readme.md
d961ac5
@frgitdaq
mkdir update in the docker file, since git deletes empty resources fo…
8323e25 
…lder
@frgitdaq
Bacnet test skip text change
f6bdcc1
@frgitdaq
mkdir path rolled back to previous working path
ec6edc9
@frgitdaq
Merge pull request #2 from frgitdaq/340-mac-oui
6d35a32 
340 mac oui
@frgitdaq
Update test_aux.out
267ef3f 
To match the travis test_aux.out
@frgitdaq
Update test_aux.out
c037fea 
Removed the changes that were added to fix the previous error, as the change is causing errors.
@frgitdaq
Update test_aux.out
b239e2b 
Re-adding result text for "protocol.bacnet.pic skip"
@frgitdaq
Update test_aux.out
0543dc0 
Removing "pics.csv..." to get the facetsdn/daq pass on travis
@frgitdaq
Readme updated
9388ad2
@frgitdaq
Update test_aux.out
bc6631b 
Reverting the change upon Trevor's advice
@frgitdaq
Update .gitignore
406a80b 
Removing the leading /
Implemented NTP network tests
953fe51
Rename NTP test
a495862
@frgitdaq
Grammar error preventing CI testing
39740b9
@frgitdaq
Matching the output file with the inst test out.
df4ce47
@frgitdaq
NTP client updated to support multiple versions. Faux device updated.
5a232b8
@frgitdaq
Remove unused networking tests
bebc708
@frgitdaq
Merge remote-tracking branch 'faucetsdn/master' into test-network
e4f34b8
@frgitdaq
Merge remote-tracking branch 'faucetsdn/master' into test-network
e9d770a
merge
eddecb9
@frgitdaq
Merge branch 'master' into test-network
7e0b3b2
@frgitdaq frgitdaq requested review from grafnu and pisuke June 17, 2020 10:04
@codecov
Copy link

codecov bot commented Jun 17, 2020 •
edited
Loading

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   79.86%   79.86%           
=======================================
  Files          21       21           
  Lines        3621     3621           
=======================================
  Hits         2892     2892           
  Misses        729      729
Flag Coverage Δ
#aux 74.97% <0.00%> (ø)
#base 76.34% <0.00%> (ø)
#dhcp 71.36% <0.00%> (ø)
#many 71.47% <0.00%> (ø)
#modules 23.44% <0.00%> (ø)
#topo 73.35% <0.00%> (ø)
Impacted Files Coverage Δ
daq/gcp.py 31.01% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f9fc8a...5373333. Read the comment docs.

grafnu
grafnu reviewed Jun 17, 2020
View reviewed changes
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to address stickler errors.

pisuke
pisuke reviewed Jun 29, 2020
View reviewed changes
@frgitdaq
Copy link
Collaborator Author

frgitdaq commented Jul 7, 2020

@grafnu @pisuke Just wanted to update, the recommended changes have been implemented and the builds as passing on Travis. If there is anything else you are waiting on, then please let me know?

@grafnu
Copy link
Collaborator

grafnu commented Jul 7, 2020

Mostly looks fine -- just one additional lingering lint error...

@frgitdaq
Copy link
Collaborator Author

frgitdaq commented Jul 7, 2020

Mostly looks fine -- just one additional lingering lint error...

@grafnu @pisuke The build has passed with the removal of the lint error

pisuke
pisuke approved these changes Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@pisuke pisuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pisuke pisuke merged commit 79768e4 into faucetsdn:master Jul 8, 2020
This was referenced Jul 21, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafnu grafnu grafnu approved these changes

@pisuke pisuke pisuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frgitdaq @grafnu @pisuke