-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend support for Python 3.10 #240
Conversation
Add Python 3.10 to the test matrix on GitHub Actions. Add Python 3.10 to setup.py.
For pooch and boule, 3.10-dev is needed because it's passed to https://github.com/actions/setup-python to set up the Python version. However, here we're passing it to https://github.com/conda-incubator/setup-miniconda so we'll need to check if they have a version of 3.10 available and how to use it. |
@santisoler I would also recommend only testing the 2 end-member versions instead of every single one (e.g 3.6 and 3.10 only). That would cut down a lot on the amount of CI we use and would catch pretty much everything we care about catching. |
… docs" This reverts commit 336885b.
Good news: now tests pass on Python 3.10! 🎉 Bad news: there's a compatibility problem between Numba and Numpy on Python 3.10 when installed through conda/mamba. Maybe we should wait until Numba add further support, or should we pin Numpy for now? |
Great! I would wait for this a bit more since there's no point adding a pinning which we'll have to remove soon anyway. |
No Python 3.10 wheels yet: https://pypi.org/project/vtk/#files https://gitlab.kitware.com/vtk/vtk/-/issues/18335 is the tracking issue. A fix has been merged: https://gitlab.kitware.com/vtk/vtk/-/issues/18335#note_1164493 but not released. For a workaround there's an unofficial build: https://gitlab.kitware.com/vtk/vtk/-/issues/18335#note_1180656 See https://discourse.vtk.org/t/vtk-9-2-0-release-cycle/8149 for planned VTK release schedule, but I don't see any of the planned release candidates at https://pypi.org/project/vtk/#history so I guess they're running a bit behind. |
Thanks for the hint @hugovk. That workaround is an unofficial build made by pyvista. In fact, in So, the things that are holding us back are:
Should we keep waiting or apply those patches now and remember to remove them in the future? cc @leouieda |
After more time than I wanted, I think we can safely extend support to Python 3.10. The tests that are failing are only for Python 3.7 (see #355). |
Bump the latest end on GitHub Actions tests to Python 3.10. Build docs in
GitHub Actions using Python 3.10. Bump environment to Python 3.10. Add Python
3.10 to setup.cfg.