This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Upgrade to Ruby 2.5 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ixandidu! thanks for the PR! This PR is doing to many things and is really hard to review. Can you split each logical unit into his own PR? thanks! and let us know if you need help with that |
|
@bronzdoc I'm sorry, my bad. I just notice that a lot of changes was supposed to be included in the rails-5.0 branch. I have update this to only include the necessary changes matches with the PR title. |
etagwerker
approved these changes
May 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequiresRAILS_SERVE_STATIC_FILESenvironment variable to be defined in production to enable serving static assets (ref: https://github.com/ombulabs/pecas/pull/57/files#diff-1d98f0039bbc6df92adee882ed99d993R25).This fix the first item listed in #55