-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#472 Inline Blocks contenteditable=false fixes #473
Conversation
…n AFTER contenteditable=false element instead of inside
…hey shouldn't, fixed compilation error caused by missing nullcheck
you probably are able to fix this issue without PR by wrapping your element in two element with contenteditable=false
|
@kyselberg I tried that just now, but same behaviour occurs. <span tabindex="0" contenteditable="false" draggable="true" class="blot-boilerplate">
<span contenteditable="false">
Placeholder
</span>
</span> If you check the file changes, you will see that contenteditable="false" is only handeled correctly for block type elements |
i see |
…possible due to startContainer.isContentEditable being undefined on text nodes
…squire into solvistas_master
…t by iterating parent nodes instead of only checking the startContainer (which does not work)
…nto github_master
…nto github_master
…ssing backspace
…eplace-parent-block attribute
I did not realize that I tried to pull request the main branch of my fork... I can also create a code sandbox if you need some practical examples of the inline contenteditable="false" element bugs in action |
Element is getting split when it shouldn't
Strange behaviour when using the insert API after inserting a contenteditable false node,
firefox_ZCvltc5qND.mp4
This pull requests fixes these bugs.