Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(.github/): update ci configs to match go-fastly and cli #925

Merged
merged 2 commits into from
Feb 13, 2025
Merged

ci(.github/): update ci configs to match go-fastly and cli #925

merged 2 commits into from
Feb 13, 2025

Conversation

anthony-gomez-fastly
Copy link
Contributor

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

@anthony-gomez-fastly anthony-gomez-fastly added the Skip-Changelog Skip changelog build check label Feb 13, 2025
@anthony-gomez-fastly anthony-gomez-fastly marked this pull request as ready for review February 13, 2025 21:18
philippschulte
philippschulte previously approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

philippschulte
philippschulte approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@philippschulte philippschulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better without the new lines. Thanks!

@anthony-gomez-fastly anthony-gomez-fastly merged commit 6700d2a into main Feb 13, 2025
13 checks passed
@anthony-gomez-fastly anthony-gomez-fastly deleted the update-build branch February 13, 2025 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippschulte philippschulte philippschulte approved these changes

@kpfleming kpfleming Awaiting requested review from kpfleming

Assignees
No one assigned
Labels
Skip-Changelog Skip changelog build check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anthony-gomez-fastly @philippschulte