Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(request_settings): don't send empty string for request_condition #722

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

Integralist
Copy link
Collaborator

The API will consider the service invalid if it has multiple instances of request_setting with the same request_condition attribute value.

This PR doesn't fix that issue. This PR change is here because it's the correct thing to do.

It doesn't help though (even though we're not sending request_condition to the API if it's an empty string) because the API itself still assigns an empty string as a default for each request_setting object, and so later on in the Terraform flow when the service is 'validated' (i.e. GET /service/<SERVICE_ID>/version/<VERSION>/validate) it will return an error because it sees there are multiple request_setting objects each with an empty string for the request_condition attribute.

@Integralist Integralist force-pushed the integralist/fix-request-condition branch from a8602f1 to eceaa01 Compare June 30, 2023 10:20
@Integralist Integralist merged commit 0927a69 into main Jun 30, 2023
@Integralist Integralist deleted the integralist/fix-request-condition branch June 30, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant