fix(request_settings): don't send empty string for request_condition #722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API will consider the service invalid if it has multiple instances of
request_setting
with the samerequest_condition
attribute value.This PR doesn't fix that issue. This PR change is here because it's the correct thing to do.
It doesn't help though (even though we're not sending
request_condition
to the API if it's an empty string) because the API itself still assigns an empty string as a default for eachrequest_setting
object, and so later on in the Terraform flow when the service is 'validated' (i.e.GET /service/<SERVICE_ID>/version/<VERSION>/validate
) it will return an error because it sees there are multiplerequest_setting
objects each with an empty string for therequest_condition
attribute.