feat(mutual_authentication): implement mTLS resource #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7e149ef to
72bbc55
Compare
mccurdyc
reviewed
Jun 2, 2023
Comment on lines
+42
to
+48
| { | ||
| ResourceName: "fastly_tls_mutual_authentication.test", | ||
| ImportState: true, | ||
| ImportStateVerify: true, | ||
| // These attributes are not stored on the Fastly API and must be ignored. | ||
| ImportStateVerifyIgnore: []string{"cert_bundle"}, | ||
| }, |
There was a problem hiding this comment.
@Integralist what does this block do?
There was a problem hiding this comment.
This validates that Terraform is able to import the resource.
There was a problem hiding this comment.
Ah makes sense. Thank you!
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestAccFastlyMTLS_validate(t *testing.T) { |
There was a problem hiding this comment.
(just vocalizing my mental model)
- generated key and cert for
<random-prefix>.example.comdomain - creates and checks resource
fastly_tls_mutual_authenticationwithname=<random-prefix> - updates resource and sets
name=<random-prefix>updated
mccurdyc
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements https://developer.fastly.com/reference/api/tls/mutual-tls/authentication/