Fix tfproviderlint errors #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6d6473d.
ErrorCheck allows providers the option to handle errors such as skipping tests based on certain errors. But we don't need to worry about that for our current test suite. Maybe in the future we'll want to add an ErrorCheck but we shouldn't feel like it's mandatory. https://github.com/bflad/tfproviderlint/tree/main/xpasses/XAT001 https://pkg.go.dev/github.com/hashicorp/terraform-plugin-sdk/v2@v2.23.0/helper/resource#TestCase
We don't want to have to manually type the key name when we already have h.GetKey()/h.Key() to return us the value. Especially if we decide to rename that key in the future. https://github.com/bflad/tfproviderlint/tree/main/passes/R001
shawnps
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
@Integralist if we're ignoring XAT001 everywhere and plan to add tfproviderlint to the build, I wonder if invoking it with tfproviderlint -XAT001=false would be better than the lintignore comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
Note: I've run the complete end-to-end integration test suite, and it's passing.