Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.0.0 Migration Guide to Documentation #551

Merged
merged 5 commits into from
Mar 2, 2022
Merged

Add 1.0.0 Migration Guide to Documentation #551

merged 5 commits into from
Mar 2, 2022

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Mar 1, 2022 •
edited
Loading

Thanks to @reidab for suggesting this change.

The guide is copied from the 1.0.0 release:
https://github.com/fastly/terraform-provider-fastly/releases/tag/v1.0.0

The guide should show up in the documentation under the following header:

- Guides
    - Migration
        - Fastly Terraform 1.0.0 Migration Guide
- Resources
- Data Sources

@Integralist Integralist requested review from a team and triblondon and removed request for a team March 1, 2022 19:45
@Integralist Integralist mentioned this pull request Mar 1, 2022
Closed
triblondon
triblondon approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@triblondon triblondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking suggestions

@Integralist Integralist merged commit d2b4b63 into main Mar 2, 2022
@Integralist Integralist deleted the integralist/migration-guide-as-example branch March 2, 2022 17:51
@reidab
Copy link

reidab commented Mar 5, 2022

🎉 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triblondon triblondon triblondon approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Integralist @reidab @triblondon