Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp fastly_tls_subscription examples #527

Merged
merged 2 commits into from
Jan 17, 2022
Merged

Conversation

smaeda-ks
Copy link
Contributor

continuing my previous PR: #516

Adding a large note in the example as it's doing fairly complex things.
We updated the example with the simplified version in the previous PR but it might not be the best option due to the limitation I left in the comment in this PR.

@smaeda-ks smaeda-ks self-assigned this Jan 15, 2022
@smaeda-ks smaeda-ks requested a review from Integralist January 15, 2022 01:21
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple of minor comments.

@smaeda-ks smaeda-ks merged commit 0e6959c into main Jan 17, 2022
@smaeda-ks smaeda-ks deleted the shohei-update-tls-example branch January 17, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants