Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to accept multi-pem blocks #469

Merged
merged 2 commits into from
Sep 8, 2021
Merged

Conversation

endzyme
Copy link
Contributor

@endzyme endzyme commented Sep 7, 2021

The API appears to accept the certificate as well as the intermediary certificates.

See #468

The API appears to accept the certificate as well as the intermediary certificates.
@smaeda-ks
Copy link
Contributor

Thanks @endzyme
Could you also update the documentation page as well?
https://github.com/fastly/terraform-provider-fastly#building-the-documentation

Or, we will push a commit to your branch.

@smaeda-ks smaeda-ks added the enhancement New feature or request label Sep 8, 2021
@smaeda-ks
Copy link
Contributor

Thanks for adding the doc change! @endzyme

@Integralist
Could you please approve? This looks good to me.

Thanks

@Integralist Integralist merged commit a8bc01f into fastly:main Sep 8, 2021
@endzyme endzyme deleted the patch-1 branch September 8, 2021 20:34
@endzyme
Copy link
Contributor Author

endzyme commented Sep 8, 2021

Thanks @smaeda-ks! Any news on when we can expect this to be released?

@smaeda-ks
Copy link
Contributor

To be clear: #468 is already addressed in our system so you no longer need to upload the full chain for the LE certs. Given that, there's no urgency at this moment, and we will be releasing a new version after #467 is merged. Maybe sometime next week.

@endzyme
Copy link
Contributor Author

endzyme commented Sep 9, 2021

Thanks again for the diligence and attention getting this through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants