Correctly update version_comment
#466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
version_comment
Integralist
approved these changes
Sep 2, 2021
|
A future improvement might be worth looping through the versions to find the one matching |
|
@bengesoff could you please elaborate on that more? I'm not following your point... sorry [updated] I think I get your point. Thanks |
|
@smaeda-ks no problem - I think your fix is a definite improvement from where it was before, but I just figured it might be another edge case to catch 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#465
This PR fixes two issues.
version_commentattribute is ignored on service creationversion_commentvalue is wrongly assigned froms.Version.Commentas opposed tos.ActiveVersion.Comments.Versioncontains the last version object regardless of its state (draft/active), so we always should look ats.ActiveVersion