Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make backend block optional #457

Merged
merged 4 commits into from
Aug 10, 2021
Merged

make backend block optional #457

merged 4 commits into from
Aug 10, 2021

Conversation

smaeda-ks
Copy link
Contributor

This addresses: #454

Note: since this changes it from required to optional, this is NOT considered as a breaking change.

@smaeda-ks smaeda-ks changed the title Smaeda ks/make backend block optional make backend block optional Jul 31, 2021
@smaeda-ks smaeda-ks self-assigned this Jul 31, 2021
@smaeda-ks smaeda-ks added the enhancement New feature or request label Jul 31, 2021
Integralist
Integralist reviewed Aug 2, 2021
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of quick clarifying questions.

@smaeda-ks smaeda-ks requested a review from Integralist August 2, 2021 12:38
@Integralist Integralist merged commit 3945d4d into fastly:main Aug 10, 2021
@bengesoff
Copy link
Contributor

@Integralist @smaeda-ks I'm running the TestAccFastlyServiceV1_createServiceWithStaticBackend test and getting a failure as there doesn't seem to be an error returned in the second step 🤔

@smaeda-ks
Copy link
Contributor Author

Hmm, it should. I'll check tomorrow

@smaeda-ks
Copy link
Contributor Author

#462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 left review comments

@Integralist Integralist Integralist approved these changes

Assignees

@smaeda-ks smaeda-ks

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smaeda-ks @bengesoff @Integralist @chenrui333