use d.SetNewComputed for TypeSet computed attributes #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Jul 29, 2021
bengesoff
reviewed
Jul 29, 2021
| @@ -25,6 +25,7 @@ func resourceFastlyTLSSubscription() *schema.Resource { | |||
| customdiff.ForceNewIf("configuration_id", resourceFastlyTLSSubscriptionStateNotIssued), | |||
| customdiff.ForceNewIf("domains", resourceFastlyTLSSubscriptionStateNotIssued), | |||
| customdiff.ForceNewIf("common_name", resourceFastlyTLSSubscriptionStateNotIssued), | |||
| resourceFastlyTLSSubscriptionSetNewComputed, | |||
There was a problem hiding this comment.
It might be marginally more readable to use the customdiff.ComputedIf() helper method instead of calling d.SetNewComputed() directly? I did a similar thing in #388 but up to you
Co-authored-by: Mark McDonnell <Integralist@users.noreply.github.com>
|
Any chance we can get this merged and a new point release created? Would love to test this in our environment :) |
|
Hi @virgofx I'll be cutting a new release on Monday morning. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to fix: #451
TODO:
Note:
I'm not adding acceptance tests for this change because the update action only runs for "issued" state:
https://github.com/fastly/terraform-provider-fastly/blob/v0.33.0/fastly/resource_fastly_tls_subscription.go#L23
If we're about to add tests, that require tests to interact with DNS records as well as waiting for the subscription to be issued, which isn't ideal in my view.
Reference:
hashicorp/terraform-plugin-sdk#195