Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set main field on CreateVCL to reduce redundant subsequent call #446

Merged
merged 1 commit into from
Jul 20, 2021
Merged

set main field on CreateVCL to reduce redundant subsequent call #446

merged 1 commit into from
Jul 20, 2021

Conversation

smaeda-ks
Copy link
Contributor

For: #112

@smaeda-ks smaeda-ks added the enhancement New feature or request label Jul 17, 2021
@smaeda-ks smaeda-ks requested a review from Integralist July 19, 2021 02:00
Integralist
Integralist approved these changes Jul 20, 2021
View reviewed changes
Copy link
Collaborator

@Integralist Integralist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Side Note: The ActivateVCL function name in go-fastly is terrible IMHO and makes it hard to know what the function is actually doing (I had to look it up in developer.fastly.com). We should fix that in future.

@Integralist Integralist merged commit a8d4356 into fastly:main Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Integralist Integralist Integralist approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smaeda-ks @Integralist