Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct 'shield' value #437

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Use correct 'shield' value #437

merged 1 commit into from
Jun 29, 2021

Conversation

Integralist
Copy link
Collaborator

@Integralist Integralist commented Jun 29, 2021 •
edited
Loading

This is a fresh PR of the issue reported in #256

Summary: change mocked response value from New York to lga-ny-us.

@Integralist Integralist requested review from acme, a team, doramatadora and kailan and removed request for a team June 29, 2021 08:47
@Integralist
Copy link
Collaborator Author

Just to confirm I've run the entire test suite locally and it's passing.

triblondon
triblondon approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@triblondon triblondon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed on zoom

@Integralist Integralist merged commit 59b7a3a into main Jun 29, 2021
@Integralist Integralist deleted the integralist/valid-shield branch June 29, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triblondon triblondon triblondon approved these changes

@acme acme Awaiting requested review from acme

@doramatadora doramatadora Awaiting requested review from doramatadora

@kailan kailan Awaiting requested review from kailan

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Integralist @triblondon