Add support for compression_codec to logging file sink endpoints #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6ad728 to
1a23940
Compare
|
@kellymclaughlin looks to be a conflict in the PR. Would you be able to take a look and I'll get this reviewed once resolved. Thanks! |
|
@kellymclaughlin FYI - might not affect this PR but the |
1a23940 to
d078fd2
Compare
|
I resolved the conflicts so should be ready to review now. |
Integralist
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
compression_codecto file-based logging endpoints. Follows from fastly/go-fastly#235.Note: There was quite a bit of whitespace inconsistency in the test files that are part of this change. I tried to make that more uniform in the files I touched so viewing the diff with the whitespace filter may be useful.