Include dns_records in TLS configuration when performing lookup by ID #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source
It was missing and dns_records weren't populated when using
data "fastly_tls_configuration" "configuration_by_id" {
id = data.fastly_tls_configuration.default_configuration.id
}
but they were populated when using any other search filter. This was
because the lookup by ID used the GetCustomTLSConfiguration call in
go-fastly whereas the others used ListCustomTLSConfigurations and
filtered them locally. Therefore the former call was missing the
required flag.
Integralist
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #391
The fix was already in the issue so a fairly easy one. I've tested it and it works as expected.