PATCH endpoint for TLS subscriptions #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integralist
reviewed
Feb 22, 2021
|
@Integralist fixed based on your feedback, and confirmed the test still passes 🙂 |
Unable to test as it requires a subscription to be in the "issued" state which would depend on another provider to handle DNS. Takes advantage of Terraform's CustomizeDiff to decide whether to update the resource in place or recreate it.
Unfortunately can't test the PATCH endpoint as it requires the subscription being in "issued" state. However, we can at least test that the resource correctly decides not to use the PATCH endpoint as a result and instead recreates the resource.
Same logic as the force_destroy argument.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
PATCHendpoint for updating TLS Subscriptions. Currently a Limited Availability feature so this won't work for all customers.Similar to the
force_destroyflag there is also aforce_updateflag which gets passed through to the API to enable making changes to production traffic. This is so you have to opt-in to this behaviour and take responsibility for the risk this may have. It is worth noting that there doesn't seem to be any case where not using this flag has any effect.It appears the
PATCHendpoint only supports updating theconfiguration_id,domains, orcommon_nameso there is aCustomizeDiffpresent to trigger a recreation of the subscription if anything else changes. Therefore thePATCHendpoint is only used if the changes are contained to these three fields.