Update Go-Fastly dependency to 3.0.0 #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doramatadora
approved these changes
Jan 29, 2021
| @@ -46,7 +46,7 @@ const DefaultRealtimeStatsEndpoint = "https://rt.fastly.com" | |||
| var ProjectURL = "github.com/fastly/go-fastly" | |||
|
|
|||
| // ProjectVersion is the version of this library. | |||
| var ProjectVersion = "2.1.0" | |||
| var ProjectVersion = "3.0.0" | |||
|
|
|||
| // UserAgent is the user agent for this particular client. | |||
There was a problem hiding this comment.
Suggested change
| // UserAgent is the user agent for this particular client. | |
| // UserAgent is the user agent for this client. |
Comment on lines
+332
to
+333
| // String implements the stringer interface and returns the string representing | ||
| // the string text that includes the status code and corresponding status text. |
There was a problem hiding this comment.
Suggested change
| // String implements the stringer interface and returns the string representing | |
| // the string text that includes the status code and corresponding status text. | |
| // String implements the string interface and returns a string | |
| // that includes the status code and corresponding status text. |
|
Thanks @doramatadora but unfortunately those edits will need to be made to the Go-Fastly repo. The terraform provider vendors its dependencies, so the files you've suggested changes to would be overwritten the next time someone runs |
|
Thank you for the explanation! In that case, this looks great. I will open a PR in Go-Fastly. |
|
Ran the full test suite and it's passing. |
11b621a to
deda1ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a new major version release for the Go-Fastly dependency. It introduces some breaking changes, which this PR addresses.
NOTE: as part of the current TLS implementation work, there will need to be changes added to a 3.x.x release of Go-Fastly and so integrating the TLS features into Terraform will be blocked until this PR is merged.