Keeping backends in directors when backends are modified #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccurdyc
reviewed
Aug 26, 2020
There was a problem hiding this comment.
This LGTM. I'd like @phamann to take a look.
Below are just suggestions, overall this change looks good to me.
I was a bit overwhelmed by the change to formatVersion to use the new helper. Was this necessary for this change? Could we pull that out into a separate branch so that this change is strictly focused on the backend/director update? The only other suggestion that I had was to pull the new Diff logic out into its own change and to update the existing codebase to use that new logic, so that if we could test it with existing resources and rollback separately, if necessary.
| @@ -67,7 +67,7 @@ func (h *SumologicServiceAttributeHandler) Process(d *schema.ResourceData, lates | |||
| URL: sf["url"].(string), | |||
| MessageType: sf["message_type"].(string), | |||
| Format: vla.format, | |||
| FormatVersion: int(vla.formatVersion), | |||
| FormatVersion: int(uintWithDefault(vla.formatVersion)), | |||
There was a problem hiding this comment.
Just noting Sumologic uses int - https://github.com/fastly/go-fastly/blob/master/fastly/sumologic.go#L21
This has been documented internally as a breaking change TODO.
…backends instead of recreating them
Acceptance Tests
|
phamann
approved these changes
Sep 2, 2020
This was referenced Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
This change is based on the Option 2 described on #197 and some further analysis to determine the best option.
I've made the Diff computation a separate component so that in the future, other parts of the code can re-use it to perform updates instead of delete/create.
I've also fixed some unrelated issues with logging endpoints on the compute resource (see commit cc7bec3) which was causing the acceptance tests to fail.
Acceptance Test results