Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WAF support #291

Merged
merged 26 commits into from
Aug 10, 2020
Merged

Add WAF support #291

merged 26 commits into from
Aug 10, 2020

Conversation

yoink00
Copy link
Contributor

@yoink00 yoink00 commented Jul 21, 2020

Changes:

  • Rebases service-waf-implementation onto master.
  • Adds WAF to the new block style code
  • Wait for WAF deployments to complete (wait for LastDeploymentStatus to become complete).
  • Mark all WAF Configuration optional fields as computed (this indicates that the default values are not known until the Terraform is applied).
  • Add an optional field to the test to ensure it is imported correctly and that a plan shows no changes

Acceptance test output (limited to just the WAF tests, updating go.mod to point to a local up-to-date go-fastly):

$ make testacc TESTARGS='-run=\'TestAccFastlyServiceV1WAF.*\''
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run='TestAccFastlyServiceV1WAF.*' -timeout 360m -ldflags="-X=github.com/terraform-providers/terraform-provider-fastly/version.ProviderVersion=acc"
?       github.com/terraform-providers/terraform-provider-fastly        [no test files]
=== RUN   TestAccFastlyServiceV1WAFAdd
=== PAUSE TestAccFastlyServiceV1WAFAdd
=== RUN   TestAccFastlyServiceV1WAFAddAndRemove
=== PAUSE TestAccFastlyServiceV1WAFAddAndRemove
=== RUN   TestAccFastlyServiceV1WAFUpdateResponse
=== PAUSE TestAccFastlyServiceV1WAFUpdateResponse
=== RUN   TestAccFastlyServiceV1WAFUpdateCondition
=== PAUSE TestAccFastlyServiceV1WAFUpdateCondition
=== CONT  TestAccFastlyServiceV1WAFAdd
=== CONT  TestAccFastlyServiceV1WAFUpdateCondition
--- PASS: TestAccFastlyServiceV1WAFAdd (55.38s)
=== CONT  TestAccFastlyServiceV1WAFUpdateResponse
--- PASS: TestAccFastlyServiceV1WAFUpdateCondition (111.94s)
=== CONT  TestAccFastlyServiceV1WAFAddAndRemove
--- PASS: TestAccFastlyServiceV1WAFUpdateResponse (106.17s)
--- PASS: TestAccFastlyServiceV1WAFAddAndRemove (152.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-fastly/fastly 264.036s
?       github.com/terraform-providers/terraform-provider-fastly/version        [no test files]

@yoink00 yoink00 changed the title Rebase and add WAF to new block style code Rebase, add WAF to new block style code and API changes Jul 21, 2020
@phamann phamann self-requested a review July 22, 2020 14:42
@phamann phamann changed the title Rebase, add WAF to new block style code and API changes Add WAF support Jul 22, 2020
oscarDovao and others added 24 commits August 7, 2020 11:25
* Service WAF component implemented
* Service WAF component implementation
*  WAF configuration resource active rules implementation
* Waf rules data source implementation
waf configuration resource deletion implementation
* WAF disabled field implemented
* WAF configuration resource import implemented
* refactored waf configuration read and update - added WAF logging entries
* Introducing Terraform provider documentation files for WAF related functionality
* making rule's revision field computed and update for POST API update
* WAF documentation enhancements
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - we're very excited to get this merged and shipped.

Thank you for all your hard work @oscarDovao @matpimenta & @yoink00 for getting this over the line.

@phamann phamann merged commit d3541e6 into fastly:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants