Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import for Compute services #286

Merged
merged 7 commits into from
Jul 15, 2020
Merged

Import for Compute services #286

merged 7 commits into from
Jul 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jul 10, 2020 •
edited by ghost
Loading

This provides a more resilient import function and provides type checking for the two different types of service when reading

@ghost ghost added the size/L label Jul 10, 2020
phamann
phamann approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM - other than the conflicts which need resolving.

@ghost
Copy link
Author

ghost commented Jul 14, 2020

Conflict resolved

@phamann phamann merged commit a50a832 into fastly:master Jul 15, 2020
@matpimenta matpimenta deleted the oc/import branch August 19, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@phamann