Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Rackspace Cloud Files logging support #275

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Adds Rackspace Cloud Files logging support #275

merged 1 commit into from
Jun 29, 2020

Conversation

mccurdyc
Copy link
Collaborator

Proposed Change(s)

  • Adds support for provisioning Rackspace Cloud Files logging endpoints.
  • Updates fastly_service_v1 docs to reflect the change.

Relevant Link(s) / Doc(s)

Validation

export FASTLY_API_KEY="foo"; export TF_ACC=1; make testacc TESTARGS='-run=[cC]loudfiles'

@mccurdyc mccurdyc requested a review from phamann June 24, 2020 14:45
@mccurdyc mccurdyc marked this pull request as ready for review June 24, 2020 14:45
phamann
phamann requested changes Jun 26, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, lets get the naming changed.

@mccurdyc mccurdyc requested a review from phamann June 29, 2020 14:48
phamann
phamann approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@phamann phamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@mccurdyc
Adds Rackspace Cloud Files logging support
c7514a6 
Signed-off-by: Colton J. McCurdy <cmccurdy@fastly.com>
@mccurdyc mccurdyc merged commit 7ece4c1 into fastly:master Jun 29, 2020
@mccurdyc mccurdyc deleted the mccurdyc/logging-rackspace branch June 29, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phamann phamann phamann approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccurdyc @phamann