Handle TLS Whitespace

[mccurdyc]

Proposed Change(s)

• Uses the StateFunc field for trimming leading and trailing whitespace characters in TLS-related fields.
  • hashicorp@412688e
  • Note that while this function does what we want, it does bring with it a bug. Here is a relevant issue documenting the bug.
  • Example use in the google provider
• Fixes an issue in the Elasticsearch tests where default values should have been expected and were not
  • hashicorp@6dfae5a
• Use cmp.Diff instead of reflect.DeepEqual in Elasticsearch flatten test.
  • hashicorp@6a2c1d6
• Moves appendNewLine helper function from Elasticsearch test to general test helpers file.
  • hashicorp@0b650ef
• Updates Splunk to use StateFunc.
  • hashicorp@6f37592
• Updates HTTPS to use StateFunc.
  • hashicorp@f689b34

Validation

export FASTLY_API_KEY="foo"; export TF_ACC=1; make testacc

[phamann]

Couple of comments/questions:

• I can see go-cmp and terraform-plugin-sdk being updated in the vendor files, however am confused as to why aws-sdk-go has changed - is it a transient dep of one of those? Not an issue now, but its easier if vendoring is self contained to a single commit to make it easier for reviewers.
• I like the StateFunc approach to this and am now left thinking we should apply this to all logging endpoints that accept certs and our backend TLS fields too. Thoughts?

[mccurdyc]

I like the StateFunc approach to this and am now left thinking we should apply this to all logging endpoints that accept certs and our backend TLS fields too. Thoughts?

Absolutely! I will work on a commits that do this.

• Splunk - hashicorp@6f37592
• HTTPS - hashicorp@f689b34

[phamann]

👍 LGTM